Repository navigation
Prevent stale pet snapshots from overwriting battle progress - #85
Open
suryaswain612 wants to merge 10 commits into
Open
suryaswain612 wants to merge 10 commits into
suryaswain612 wants to merge 10 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🧪 Coverage
|
heyradcode
requested changes
Oct 22, 2026
heyradcode
requested changes
Oct 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accept read pet progress before
openBattletook the pet locks. A pet still finishing another battle could be snapshotted with old progress, skip that battle's cooldown, and later overwrite its result.openBattlenow rechecks the frozen progress after taking the locks, with a guardedupdateManyper pet in lock order. A plain read would return the transaction's old snapshot, so it could still commit stale data.409 pet-locked.P2034) is retried up to 3 times instead of returning a 500.Not included: a refused accept still spends one of the defender's daily uses (M2), and the verifier does not yet check per-pet receipt continuity.
Related Issue(s)
#80
Type of Change
Component(s)
How Has This Been Tested?
pnpm --filter backend lintpnpm --filter backend test(1,114 tests pass)pnpm --filter backend exec tsc --noEmitAlso ran the real
openBattleagainst a local Postgres. Without the recheck, a battle opened on stale progress, both when progress changed before open and when another battle signed during the accept. With this PR, both are refused cleanly. Concurrent accepts (20 rounds each, 80 calls) always had exactly one winner and no 500s.Checklist